Do not add unexpected FORMAT JSON for not distributed queries#216
Merged
isublimity merged 1 commit intosmi2:masterfrom Jul 4, 2024
Merged
Do not add unexpected FORMAT JSON for not distributed queries#216isublimity merged 1 commit intosmi2:masterfrom
isublimity merged 1 commit intosmi2:masterfrom
Conversation
Contributor
Author
|
@isublimity please, check this PR. It seems you are the only maintainer here |
Contributor
|
Thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That changes #190 prevent that queries from being executed:
CREATE FUNCTION ...orDROP FUNCTION ...The proposed solution in pull request #214 resolves this specific issue. However, it's essential to acknowledge that this fix might introduce potential compatibility issues with existing codebases.
It seems that the changes made in #190 addressed a specific case, but other common scenarios may have been overlooked, so I've implemented an early exit from function when
ON CLUSTERdoes not exist.